Skip to content

Conversation

arjansingh
Copy link
Contributor

@arjansingh arjansingh commented Sep 15, 2025

Summary

Per @christian-byrne's feedback. Just bringing this into the repo sooner to clean up my feature branch.

Changes

  1. creates /src/platform/assets directories
  2. moves existing service and schema into this directory
  3. fix any broken imports

┆Issue is synchronized with this Notion page by Unito

@arjansingh arjansingh requested review from a team as code owners September 15, 2025 20:45
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 15, 2025
Copy link

github-actions bot commented Sep 15, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 09/15/2025, 09:16:42 PM UTC

📈 Summary

  • Total Tests: 449
  • Passed: 419 ✅
  • Failed: 0
  • Flaky: 1 ⚠️
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 412 / ❌ 0 / ⚠️ 1 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@DrJKL
Copy link
Contributor

DrJKL commented Sep 15, 2025

I love the move otherwise 😄

Per @christian-byrne's feedback. Just bringing this into the repo sooner to clean up from my feature branch
@arjansingh arjansingh force-pushed the refactor/assets-location branch from 1ac6484 to c294913 Compare September 15, 2025 20:57
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 15, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 15, 2025
@DrJKL DrJKL assigned christian-byrne and unassigned arjansingh Sep 15, 2025
@christian-byrne christian-byrne merged commit e601bcb into main Sep 15, 2025
25 checks passed
@christian-byrne christian-byrne deleted the refactor/assets-location branch September 15, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:assets size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants